Skip to content

Make model path mandatory in export to ONNX. - #641

Merged
codemzs merged 1 commit into
dotnet:masterfrom
codemzs:onnx
Aug 8, 2018
Merged

Make model path mandatory in export to ONNX.#641
codemzs merged 1 commit into
dotnet:masterfrom
codemzs:onnx

Conversation

@codemzs

@codemzs codemzs commented Aug 3, 2018

Copy link
Copy Markdown
Member

fixes #423

@codemzs
codemzs requested review from wschin and zeahmed August 3, 2018 06:04
@codemzs

codemzs commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

dotnet build Linux Build_Debug

@codemzs

codemzs commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

@dotnet-bot test this please

@zeahmed zeahmed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codemzs! looks good to me.

@wschin wschin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codemzs
codemzs merged commit 4b60064 into dotnet:master Aug 8, 2018
@codemzs
codemzs deleted the onnx branch August 8, 2018 17:15
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Onnx path parameter mandatory in OnnxConverter

3 participants